Skip to content

fix(hmr): close modal views during livesync #7669 #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2019

Conversation

VladimirAmiorkov
Copy link
Contributor

@VladimirAmiorkov VladimirAmiorkov commented Aug 12, 2019

PR depends on this one to be release first: NativeScript/NativeScript#7679

PR Checklist

What is the current behavior?

Any opened modal views are not updated or closed during HMR livesync

What is the new behavior?

Any opened modal views are closed during HMR livesync

Fixes/Implements/Closes #[Issue Number].
#1854

@VladimirAmiorkov VladimirAmiorkov self-assigned this Aug 12, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 12, 2019
@VladimirAmiorkov
Copy link
Contributor Author

test tns-core-modules#rc

1 similar comment
@VladimirAmiorkov
Copy link
Contributor Author

test tns-core-modules#rc

@VladimirAmiorkov VladimirAmiorkov marked this pull request as ready for review August 26, 2019 10:52
@VladimirAmiorkov VladimirAmiorkov merged commit 73d83ed into master Aug 27, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/hmr-modals-fix branch August 27, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants